October to April is when most cabins are sold, and for a reason. You can stand in the Valley of the Kings at nine in the morning and still think. Christmas and Easter cost more and feel busier on the quay at Edfu.
May and September are the shoulder. The ships discount, the temples are workable if you start early, and a dahabiya is at its best because you are not racing a convoy.
June through August is hot in a way photographs do not admit. We still run cruises. We just refuse a timetable that puts you in the valley at noon. If you want those months, say so, and we will build the days around shade and early gates.
What we would book
A first visit: late October, or any week in February that is not a holiday. A second visit, when you already know Karnak: a dahabiya in May, with fewer boats on the water.